netdev - Re: [PATCH 2/9] net-ethtool: Convert (hw_/vlan_/wanted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikjhY-M7ZB8azYctq9p1ORmA8PBKQ@mail.gmail.com>
Date:	Mon, 25 Apr 2011 10:48:52 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/9] net-ethtool: Convert (hw_/vlan_/wanted_)features
 fields from u32 type to u64.

2011/4/23 Mahesh Bandewar <maheshb@...gle.com>:
>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> ---
>  include/linux/ethtool.h |   26 +++++++------
>  net/core/ethtool.c      |   89 ++++++++++++++++------------------------------
>  2 files changed, 45 insertions(+), 70 deletions(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 9de3127..71e8a02 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -605,10 +605,10 @@ struct ethtool_flash {
>  * @never_changed: mask of features not changeable for any device
>  */
>  struct ethtool_get_features_block {
> -       __u32   available;
> -       __u32   requested;
> -       __u32   active;
> -       __u32   never_changed;
> +       __u64   available;
> +       __u64   requested;
> +       __u64   active;
> +       __u64   never_changed;
>  };
[...]

Please don't do it like this. G/SFEATURES were prepared to handle
multiple words when needed. This means that it's enough to just split
the u64 into two u32 sets represented in ethtool_get/set_features.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html