netdev - Re: [PATCH net-next-2.6 4/7] sctp: remove useless arguments from get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110426.001227.112589346.davem@davemloft.net>
Date:	Tue, 26 Apr 2011 00:12:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 4/7] sctp: remove useless arguments from
 get_saddr() call

From: Wei Yongjun <yjwei@...fujitsu.com>
Date: Tue, 26 Apr 2011 11:47:39 +0800

> @@ -392,11 +392,11 @@ static inline int sctp_v6_addr_match_len(union sctp_addr *s1,
>   */
>  static void sctp_v6_get_saddr(struct sctp_sock *sk,
>  			      struct sctp_transport *t,
> -			      union sctp_addr *daddr,
>  			      struct flowi *fl)
>  {
>  	struct flowi6 *fl6 = &fl->u.ip6;
>  	union sctp_addr *saddr = &t->saddr;
> +	union sctp_addr *daddr = &t->ipaddr;
>  
>  	SCTP_DEBUG_PRINTK("%s: asoc:%p dst:%p daddr:%pI6 ",
>  			  __func__, t->asoc, t->dst, &daddr->v6.sin6_addr);

I really get grumpy when I have to fix up stuff like this:

net/sctp/ipv6.c: In function ‘sctp_v6_get_saddr’:
net/sctp/ipv6.c:382: warning: unused variable ‘daddr’

You guys know I'm going to immediately run make on any patch you send
me and look for new warnings.

Why waste my time and not look for them yourselves before posting the
patch?

This wasn't even one of those cases where the warning goes away at
the end of the patch series, and only exists somewhere in the middle.