netdev - Re: [PATCH net-next-2.6 4/7] sctp: remove useless arguments from get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110426.002020.48493363.davem@davemloft.net>
Date:	Tue, 26 Apr 2011 00:20:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 4/7] sctp: remove useless arguments from
 get_saddr() call

From: David Miller <davem@...emloft.net>
Date: Tue, 26 Apr 2011 00:12:27 -0700 (PDT)

> I really get grumpy when I have to fix up stuff like this:
> 
> net/sctp/ipv6.c: In function ‘sctp_v6_get_saddr’:
> net/sctp/ipv6.c:382: warning: unused variable ‘daddr’

Now I'm even more grumpy, if I only apply the first 3 patches:

net/sctp/ipv6.c: In function ‘sctp_v6_dst_lookup’:
net/sctp/ipv6.c:259: warning: assignment makes integer from pointer without a cast

it goes away later but you're not testing the intermediate steps
of your SCTP patch backports and as a result you are going to
break bisecting.

I'm reverting this patch series, fix this up and actually test
the intermediate builds and functionality before resubmission.