netdev - Re: [PATCH rfc 1/5] r8169: style cleanups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110427.140043.183040785.davem@davemloft.net>
Date:	Wed, 27 Apr 2011 14:00:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH rfc 1/5] r8169: style cleanups.

From: Joe Perches <joe@...ches.com>
Date: Wed, 27 Apr 2011 13:59:34 -0700

> On Wed, 2011-04-27 at 22:36 +0200, Francois Romieu wrote:
>> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> []
>> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> []
>> @@ -3134,8 +3128,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
> []
>> -	if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||
>> -	    tp->mac_version == RTL_GIGA_MAC_VER_33)
>> +	if ((tp->mac_version == RTL_GIGA_MAC_VER_32) ||
>> +	    (tp->mac_version == RTL_GIGA_MAC_VER_33))
> 
> Shrug.  I don't think this is better.

Yeah, same here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html