netdev - Re: [PATCH 3/4] ipv4: Remove erroneous check in igmpv3_newpack() and igmp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1303879808.2699.46.camel@edumazet-laptop>
Date:	Wed, 27 Apr 2011 06:50:08 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] ipv4: Remove erroneous check in igmpv3_newpack()
 and igmp_send_report().

Le mardi 26 avril 2011 à 15:12 -0700, David Miller a écrit :
> Output route resolution never returns a route with rt_src set to zero
> (which is INADDR_ANY).
> 
> Even if the flow key for the output route lookup specifies INADDR_ANY
> for the source address, the output route resolution chooses a real
> source address to use in the final route.
> 
> This test has existed forever in igmp_send_report() and David Stevens
> simply copied over the erroneous test when implementing support for
> IGMPv3.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Reviewed-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html