netdev - Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110428.134241.70176095.davem@davemloft.net>
Date:	Thu, 28 Apr 2011 13:42:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	joe@...ches.com, mchan@...adcom.com, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Wed, 27 Apr 2011 09:28:21 -0700

> On Tue, Apr 26, 2011 at 11:12:10AM -0700, Joe Perches wrote:
>> Using a bitmap instead of separate u32 flags allows a consistent, simpler
>> and more extensible mechanism to determine capabilities.
>> 
>> Convert bitmasks to enum.
>> Add tg3_flag, tg3_flag_clear and tg3_flag_set.
>> Convert the flag & bitmask tests.
>> 
>> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> I looked through it and didn't see any problems.  I've queued
> Michael Chan's suggestion into my queue.
> 
> Acked-by: Matt Carlson <mcarlson@...adcom.com>

I've applied Joe's change to net-next-2.6, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html