netdev - usbnet: why is by default dev->rx_urb_size equal to dev->hard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BANLkTim-h9F93D7xk1sHuEzfrzbgMCgFgQ@mail.gmail.com>
Date:	Thu, 28 Apr 2011 18:00:12 -0500
From:	DMITRIY GRUZMAN <xmb836@...orola.com>
To:	netdev@...r.kernel.org
Subject: usbnet: why is by default dev->rx_urb_size equal to dev->hard_mtu?

Hello,

Currently, usbnet_probe() in drivers/net/usb/usbnet.c driver sets
dev->rx_urb_size equal to dev->hard_mtu unless the dev->rx_urb size is
previously set in the bind() call.  I do not think that there is any
correlation between those values and I think that setting
dev->rx_urb_size to dev->maxpacket would be more appropriate.

Please provide your comments so I know if I should proceed with making
such a change.

Thanks,

Dmitriy Gruzman
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html