netdev - Re: [PATCH] net: ftmac100: fix scheduling while atomic during PHY link status change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinB1FiHYX1KoO90UepmhQdXZs0eEg@mail.gmail.com>
Date:	Thu, 28 Apr 2011 17:11:35 +0800
From:	Po-Yu Chuang <ratbert.chuang@...il.com>
To:	Adam Jaremko <adam.jaremko@...il.com>
Cc:	Ratbert Po-Yu Chuang(莊博宇) 
	<ratbert@...aday-tech.com>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] net: ftmac100: fix scheduling while atomic during PHY
 link status change

Hi Adam,

2011/4/27 Adam Jaremko <adam.jaremko@...il.com>:
> Signed-off-by: Adam Jaremko <adam.jaremko@...il.com>
> ---
>  drivers/net/ftmac100.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ftmac100.c b/drivers/net/ftmac100.c
> index a316619..9bd7746 100644
> --- a/drivers/net/ftmac100.c
> +++ b/drivers/net/ftmac100.c
> @@ -139,11 +139,11 @@ static int ftmac100_reset(struct ftmac100 *priv)
>                         * that hardware reset completed (what the f*ck).
>                         * We still need to wait for a while.
>                         */
> -                       usleep_range(500, 1000);
> +                       udelay(500);
>                        return 0;
>                }
>
> -               usleep_range(1000, 10000);
> +               udelay(1000);
>        }
>
>        netdev_err(netdev, "software reset failed\n");
> @@ -772,7 +772,7 @@ static int ftmac100_mdio_read(struct net_device
> *netdev, int phy_id, int reg)
>                if ((phycr & FTMAC100_PHYCR_MIIRD) == 0)
>                        return phycr & FTMAC100_PHYCR_MIIRDATA;
>
> -               usleep_range(100, 1000);
> +               udelay(100);
>        }
>
>        netdev_err(netdev, "mdio read timed out\n");
> @@ -801,7 +801,7 @@ static void ftmac100_mdio_write(struct net_device
> *netdev, int phy_id, int reg,
>                if ((phycr & FTMAC100_PHYCR_MIIWR) == 0)
>                        return;
>
> -               usleep_range(100, 1000);
> +               udelay(100);
>        }
>
>        netdev_err(netdev, "mdio write timed out\n");
> --
> 1.7.4.4
>

Not sure if your patch is indeed corrupt or it's my fault
while downloading patch from gmail:

ERROR: patch seems to be corrupt (line wrapped?)
#62: FILE: drivers/net/ftmac100.c:771:
*netdev, int phy_id, int reg)

total: 1 errors, 0 warnings, 31 lines checked

ftmac100-fix.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


Except that,

Acked-by: Po-Yu Chuang <ratbert@...aday-tech.com>

best regards,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html