netdev - Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTiku9A3V0kbj+tcO8Sp4o_JZ=d2jzg@mail.gmail.com>
Date:	Thu, 28 Apr 2011 08:16:34 -0700
From:	David Decotigny <decot@...gle.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ben Hutchings <bhutchings@...arflare.com>,
	mirq-linux@...e.qmqm.pl,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Eilon Greenstein <eilong@...adcom.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	e1000-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks
 with cleaned data

Hi,

Stanislaw, as Ben mentions, it's calling phy_ethtool_sset() which is
certainly meant to be an ETHTOOL_SSET op (from its name and comments)
even though its current implementation doesn't actually care for the
value of the cmd field.

Regards,

--
David Decotigny



On Thu, Apr 28, 2011 at 12:34 AM, Stanislaw Gruszka <sgruszka@...hat.com> wrote:
> On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:
>> --- a/drivers/net/stmmac/stmmac_ethtool.c
>> +++ b/drivers/net/stmmac/stmmac_ethtool.c
>> @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,
>>
>>       if (phy->autoneg) {
>>               if (netif_running(netdev)) {
>> -                     struct ethtool_cmd cmd;
>> +                     struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
>>                       /* auto-negotiation automatically restarted */
>> -                     cmd.cmd = ETHTOOL_NWAY_RST;
>
> Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html