netdev - Re: [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4DBA87B6020000780003ED74@vpn.id2.novell.com>
Date:	Fri, 29 Apr 2011 08:41:10 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<shemminger@...ux-foundation.org>,
	<bridge@...ts.linux-foundation.org>, <jeffm@...e.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] bridge: Module use count must be updated as
	 bridges are created/destroyed

>>> On 29.04.11 at 09:25, David Miller <davem@...emloft.net> wrote:
> From: "Jan Beulich" <JBeulich@...ell.com>
> Date: Fri, 29 Apr 2011 08:21:14 +0100
> 
>> Otherwise 'modprobe -r' on a module having a dependency on bridge will
>> implicitly unload bridge, bringing down all connectivity that was using
>> bridges.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>> Cc: Jeff Mahoney <jeffm@...e.com>
> 
> All network device drivers behave exactly the same way, when you rmmod
> the thing we unconfigure all the routes, addresses, etc. going through
> that device and let you unload it.
> 
> And this behavior is very much intentional.
> 
> Don't add an exception here.

You talk of rmmod on the very module, but the issue is about
modprobe -r on a dependent module. I cannot believe you consider
it correct that *implicit* unloading of bridge.ko should happen when
bridges are configured.

If the solution proposed isn't satisfactory, can you suggest a better
alternative still serving the purpose?

Jan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html