netdev - Re: Re: [v2 PATCH 0/6] IPVS: init and cleanup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <r17gk8q.3093bdc5574395547ee5937d82a3241c@obelix.schillstrom.com>
Date:	Fri, 29 Apr 2011 10:17:06 +0200 (CEST)
From:	"Hans Schillstrom" <hans@...illstrom.com>
To:	"Julian Anastasov" <ja@....bg>
Cc:	horms@...ge.net.au, ebiederm@...ssion.com,
	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, hans.schillstrom@...csson.com
Subject: Re: Re: [v2 PATCH 0/6] IPVS: init and cleanup.

Hello
>
>Hello,
>
>On Fri, 29 Apr 2011, Hans Schillstrom wrote:
>
>> This patch series handles exit from a network name space.
>> 
>> REVISION
>> 
>> This is version 3
>
>	Great! Only one missing lock:

Ooops..

>
>Patch 3:
>	Missing write_[un]lock_bh(&__ip_vs_svc_lock) in ip_vs_flush,
>	now we use ip_vs_unlink_service_nolock.
>
>As you are going to create new version you can look also at these:
>
>Patch 5:
>	Can you rename 'goto exit;' to 'goto cleanup;' or
>	'goto out;'
>
>Patch 6:
>	Add at least one comma after 'enabled' here:
>	netns(%d) enabled first service added
>
I'll send a new set.

Thanks
Hans


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html