netdev - Re: [PATCH] bnx2: cancel timer on device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304104851.12355.125.camel@nseg_linux_HP1.broadcom.com>
Date:	Fri, 29 Apr 2011 12:20:51 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Neil Horman" <nhorman@...driver.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bnx2: cancel timer on device removal


On Tue, 2011-04-26 at 13:30 -0700, Neil Horman wrote:
> Fix the problem by ensuring that the timer is stopped when
> pci_device_unregister
> is called.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> Reported-by: Hushan Jia <hjia@...hat.com>
> CC: Michael Chan <mchan@...adcom.com>
> CC: "David S. Miller" <davem@...emloft.net>

Thanks Neil.

Acked-by: Michael Chan <mchan@...adcom.com>

> ---
>  drivers/net/bnx2.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index bf729ee..7f76d4c 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -8358,6 +8358,8 @@ bnx2_remove_one(struct pci_dev *pdev)
>  
>         unregister_netdev(dev);
>  
> +       del_timer_sync(&bp->timer);
> +
>         if (bp->mips_firmware)
>                 release_firmware(bp->mips_firmware);
>         if (bp->rv2p_firmware)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html