| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110430101647.GC2658@psychotron.orion> Date: Sat, 30 Apr 2011 12:16:48 +0200 From: Jiri Pirko <jpirko@...hat.com> To: Michał Mirosław <mirqus@...il.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, xemul@...nvz.org Subject: Re: [PATCH net-next-2.6] veth: remove unneeded ifname code from veth_newlink() Fri, Apr 22, 2011 at 11:49:40AM CEST, mirqus@...il.com wrote: >W dniu 22 kwietnia 2011 11:43 użytkownik Michał Mirosław ><mirqus@...il.com> napisał: >> 2011/1/24 Jiri Pirko <jpirko@...hat.com>: >>> The code is not needed because tb[IFLA_IFNAME] is already >>> processed in rtnl_newlink(). Remove this redundancy. >> Hi. This patch broke creation of veth devices. Reverting it fixes the issue. >> >> Symptoms: >> >> icybox:~# ip link add type veth >> RTNETLINK answers: File exists >> icybox:~# ip link add type veth peer veth1 >> icybox:~# ip addr >> [...] >> 56: D: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000 >> link/ether e6:57:58:52:03:50 brd ff:ff:ff:ff:ff:ff >> 57: veth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000 >> link/ether c2:c2:a2:d5:d5:3a brd ff:ff:ff:ff:ff:ff > >Hmm. I was too quick. Reverting it fixes only first problem - "ip link >add type veth" adds new veth pair now, but "ip link add type veth peer >veth1" gives the same result as above. I gusee you should do: ip link add type veth peer name veth1 > >Best Regards, >Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists