netdev - Re: [PATCH] linux/stmmac.h: include <linux/platform_device.h> to remove compilation warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DBEA791.4010900@st.com>
Date:	Mon, 02 May 2011 14:46:09 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	netdev@...r.kernel.org, shiraz.hashim@...com,
	armando.visconti@...com, deepak.sikri@...com,
	viresh.linux@...il.com
Subject: Re: [PATCH] linux/stmmac.h: include <linux/platform_device.h> to
 remove compilation warning.

On 5/2/2011 8:30 AM, Viresh Kumar wrote:
> stmmac.h uses struct platform_device and doesn't include
> <linux/platform_device.h>. And so we get following compilation warning while
> using this file:
> 	warning: ‘struct platform_device’ declared inside parameter list
> 
> This patch includes <linux/platform_device.h> in stmmac.h to remove this warning

Hi Viresh

thanks for the patch that looks good for me.
We could also remove this inclusion (see commit
1f0f63885658889b3bcb8a08fbcb9532f8e536c9) from
drivers/net/stmmac/stmmac.h and keep it in linux/stmmac.h as you suggested.

What do you think?

Regards
Peppe

> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
> ---
>  include/linux/stmmac.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index 73d9b4e..d7dfe7d 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -26,6 +26,8 @@
>  #ifndef __STMMAC_PLATFORM_DATA
>  #define __STMMAC_PLATFORM_DATA
>  
> +#include <linux/platform_device.h>
> +
>  #define STMAC_TYPE_0	0
>  #define STMAC_TYPE_1	1
>  #define STMAC_TYPE_2	2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html