netdev - Re: [PATCH 1/2] usbnet: Style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304449559.1788.33.camel@Joe-Laptop>
Date:	Tue, 03 May 2011 12:05:59 -0700
From:	Joe Perches <joe@...ches.com>
To:	Oliver Neukum <oneukum@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usbnet: Style cleanups

On Tue, 2011-05-03 at 20:49 +0200, Oliver Neukum wrote:
> Am Dienstag, 3. Mai 2011, 20:17:57 schrieb Joe Perches:
> >  drivers/net/usb/usbnet.c |  625 +++++++++++++++++++++++----------------------
> >  1 files changed, 319 insertions(+), 306 deletions(-)
> > 
> > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> > index 7bc9852..28aecbb 100644
> > --- a/drivers/net/usb/usbnet.c
> > +++ b/drivers/net/usb/usbnet.c
> > @@ -30,8 +30,8 @@
> >   * issues can usefully be addressed by this framework.
> >   */
> >  
> > -// #define     DEBUG                   // error path messages, extra info
> > -// #define     VERBOSE                 // more; success messages
> > +/* #define     DEBUG                   // error path messages, extra info */
> > +/* #define     VERBOSE                 // more; success messages */
> 
> Hi,

Hi Oliver.

> 1. please don't touch things like that. They are not comments in a semantic sense

We disagree.  Look for other uses of commented out DEBUG.

For instance, in drivers it's:
$ grep -rP --include=*.[ch] --exclude=drivers/staging "/\*\s*\#\s*define\s+DEBUG\b" drivers | wc -l
32

$ grep -rP --include=*.[ch] --exclude=drivers/staging "//\s*\#\s*define\s+DEBUG\b" drivers | wc -l
17

Treewide, there are 20 uses of //#define DEBUG

> if you are touching comments, please redo the multiline comments according to
> the coding style.

Read the patches, they are converted to appropriate form.

> 3. please delay these modifications until the patches against the oom problem have
> been applied

I think they're correct and don't feel a need to regenerate them
nor do I think micropatches for trivial stuff like this is necessary.

You want to be the maintainer for this stuff, it's your choice to
apply them, modify them to suit your taste or ignore them.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html