netdev - Re: [PATCHv3 2/2] tg3: Allow ethtool to enable/disable loopback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110504015206.GA28029@mcarlson.broadcom.com>
Date:	Tue, 3 May 2011 18:52:06 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Mahesh Bandewar" <maheshb@...gle.com>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"David Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"Michael Chan" <mchan@...adcom.com>,
	"Ben Hutchings" <bhutchings@...arflare.com>,
	"Micha? Miros?aw" <mirq-linux@...e.qmqm.pl>,
	"Tom Herbert" <therbert@...gle.com>
Subject: Re: [PATCHv3 2/2] tg3: Allow ethtool to enable/disable
 loopback.

On Tue, May 03, 2011 at 06:18:55PM -0700, Mahesh Bandewar wrote:
> +	/*
> +	 * Add loopback capability only for a subset of devices that support
> +	 * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY
> +	 * loopback for the remaining devices.
> +	 */
> +	if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
> +	    !tg3_flag(tp, CPMU_PRESENT))
> +		/* Add the loopback capability */
> +		dev->hw_features |= NETIF_F_LOOPBACK;

s/||/&&/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html