netdev - Re: [PATCH] net/bonding: bonding: Adjust coding style for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304552993.1788.135.camel@Joe-Laptop>
Date:	Wed, 04 May 2011 16:49:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Rafael Azenha Aquini <aquini@...ux.com>,
	kernel-janitors.vger.kernel.org@....tchesoft.com,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/bonding: bonding: Adjust coding style for bond_3ad
 files.

On Wed, 2011-05-04 at 16:38 -0700, Stephen Hemminger wrote:
> On Wed, 4 May 2011 19:18:47 -0300
> Rafael Azenha Aquini <aquini@...ux.com> wrote:
> > -// compare MAC addresses
> >  #define MAC_ADDRESS_COMPARE(A, B) memcmp(A, B, ETH_ALEN)
> >  static struct mac_addr null_mac_addr = { { 0, 0, 0, 0, 0, 0 } };
> These should be changed to use compare_ether_addr and is_zero_ether_addr
> routines in etherdevice.h

Hey Stephen.

null_mac_addr is used as a struct and should not be changed
to is_zero_ether_addr.
Maybe the uses could be changed to a memset, but I seem to
recall the code gets bigger.

drivers/net/bonding/bond_3ad.c:1637:		aggregator->partner_system = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1660:		aggregator->aggregator_mac_address = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1696:		port->actor_system = null_mac_addr;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html