netdev - Re: [PATCH] [RFC] vlan: fix updating wanted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2011 08:51:53 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Yi Zou <yi.zou@...el.com>
Cc:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	devel@...n-fcoe.org
Subject: Re: [PATCH] [RFC] vlan: fix updating wanted_features for vlan
 device

On Wed, May 04, 2011 at 05:48:42PM -0700, Yi Zou wrote:
> commit 8a0427b "vlan: convert VLAN devices to use ndo_fix_features()" converts the
> vlan to support ndo_fix_features. However, the wanted_features is not updated
> for the vlan device, causing real_dev->features not be populated to the vlan
> device when real_dev->features are changed by the driver through FEAT_CHANGE.
> This is breaking FCoE related netdev feature flags on vlan devices. Add updating
> wanted_features to vlan_transfer_features() so netdev_get_wanted_features() will
> can get the updated wanted feature flags for vlan device properly.

Can you describe the situation further? There might be problems if device
changes its vlan_features after creation of VLAN devices on top (bonding?).

dev->wanted_features is only what user wants to get and should not be changed
by anything else.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html