netdev - Re: [PATCH 2/2 net-next] net: drivers: set TSO/UFO offload option explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 May 2011 10:54:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shanwei@...fujitsu.com
Cc:	netdev@...r.kernel.org, rusty@...tcorp.com.au, mst@...hat.com,
	eric.dumazet@...il.com, mirq-linux@...e.qmqm.pl, mirqus@...il.com,
	bhutchings@...arflare.com, dm@...lsio.com
Subject: Re: [PATCH 2/2 net-next] net: drivers: set TSO/UFO offload option
 explicitly

From: Shan Wei <shanwei@...fujitsu.com>
Date: Fri, 29 Apr 2011 13:34:45 +0800

> The device drivers should not use NETIF_F_ALL_TSO mask to set hw_features(or features),
> but have to explicitly set offload option. Because, This would make drivers automatically
> clain to support any new TSO feature an the moment of NETIF_F_ALL_TSO is expanded.
> 
> Some code style tuning. Just compile test. 
> 
> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>

But loopback is special.  It can support anything the kernel stack can emit.

So for loopback, using NETIF_F_ALL_TSO is in fact appropriate.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html