netdev - Re: [PATCH] net/bonding: adjust codingstyle for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110506145602.GA5591@x61.tchesoft.com>
Date:	Fri, 6 May 2011 11:56:04 -0300
From:	Rafael Aquini <aquini@...ux.com>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	David Miller <davem@...emloft.net>, Joe Perches <joe@...ches.com>,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>, shemminger@...tta.com,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files.

Howdy Nicolas,

On Fri, May 06, 2011 at 03:01:14PM +0200, Nicolas Kaiser wrote:
> The indentation of parentheses looks correct to me in the original version.
> However, this expression can also be simplified like
> 
>                 if (active && active->lag_ports &&
>                     active->lag_ports->is_enabled &&
> -                   (__agg_has_partner(active) ||
> -                    (!__agg_has_partner(active) && !__agg_has_partner(best)))) {
> +                   (__agg_has_partner(active) || !__agg_has_partner(best))) {
>                         if (!(!active->actor_oper_aggregator_key &&
>                               best->actor_oper_aggregator_key)) {
>                                 best = NULL;
> 
> Last October I submitted such a patch which also simplified the
> double negation in the subsequent expression.

Thanks for the feedback!

Send me this patch of yours, I'll try to merge our paths and resubmit adding
you as a signer as well 

Cheers!
-- 
Rafael Aquini <aquini@...ux.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html