lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 May 2011 18:51:40 -0700 From: Joe Perches <joe@...ches.com> To: aquini@...ux.com Cc: kernel-janitors@...r.kernel.org, David Miller <davem@...emloft.net>, Jay Vosburgh <fubar@...ibm.com>, Andy Gospodarek <andy@...yhouse.net>, shemminger@...tta.com, netdev@...r.kernel.org, Nicolas Kaiser <nikai@...ai.net> Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files On Fri, 2011-05-06 at 22:27 -0300, Rafael Aquini wrote: > @@ -411,36 +406,32 @@ static inline void __initialize_port_locks(struct port *port) > */ > static u16 __ad_timer_to_ticks(u16 timer_type, u16 par) > { > - u16 retval = 0; /* to silence the compiler */ > + u16 retval = 0; I think it's not good to remove this sort of comment. (there are others like it) Another option might be to add __maybe_unused -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists