netdev - Re: [PATCHv2] forcedeth: Allow ethtool to enable/disable loopback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110508.155759.200382648.davem@davemloft.net>
Date:	Sun, 08 May 2011 15:57:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCHv2] forcedeth: Allow ethtool to enable/disable loopback.

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Wed,  4 May 2011 18:36:40 -0700

> @@ -4502,6 +4549,9 @@ static int nv_set_features(struct net_device *dev, u32 features)
>  
>  		spin_unlock_irq(&np->lock);
>  	}
> +	if ((changed & NETIF_F_LOOPBACK) && netif_running(dev)) {
> +		nv_set_loopback(dev, features);
> +	}
>  

Please do not create a braced basic block just for a single
line of code.  Simply:

> +	if ((changed & NETIF_F_LOOPBACK) && netif_running(dev))
> +		nv_set_loopback(dev, features);

is sufficient.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html