netdev - Re: [PATCH] net/bonding: adjust codingstyle for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110508.161012.258121848.davem@davemloft.net>
Date:	Sun, 08 May 2011 16:10:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hlovdal@...il.com
Cc:	mfmooney@...il.com, joe@...ches.com, aquini@...ux.com,
	kernel-janitors@...r.kernel.org, fubar@...ibm.com,
	andy@...yhouse.net, shemminger@...tta.com, netdev@...r.kernel.org,
	nikai@...ai.net
Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files

From: Håkon Løvdal <hlovdal@...il.com>
Date: Mon, 9 May 2011 01:08:44 +0200

> On 7 May 2011 21:35, matt mooney <mfmooney@...il.com> wrote:
>> But isn't the preferred style to have a single exit point?
> 
> This is generally considered to be a bad advice, see
> http://stackoverflow.com/questions/1701686/why-should-methods-have-a-single-entry-and-exit-points/1701721#1701721
> for instance.

That article totally ignores the issue of locking and how hard it is
to get right without single exit points, and how unlocking in
multiple spots bloats up the code.

Definitely don't take that article's advice when working on the
kernel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html