netdev - [PATCH 0/15] Pass keys down to ip_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 08 May 2011 15:37:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	netdev@...r.kernel.org
Subject: [PATCH 0/15] Pass keys down to ip_queue_xmit()

The final goal of this set of changes is to normalize all uses
of ip_queue_xmit() and how sockets are connected up so that
ip_queue_xmit() can elide it's usage of rt->rt_{src,dst}

Along the way I found some locking problems in L2TP fixed here.

Basically we reuse inet_sk->cork.fl to store keying information
and pass that (or something more appropriate) to ip_queue_xmit()

This opens up the door for SCTP to express exactly what is does, by
passing in a flow which is now added to the individual transport
instances.

Taking this one step further, we could add a "struct dst **dst"
argument to ->queue_xmit() and friends, then SCTP could pass in
"&transport->dst" and it would no longer need to do that special
"pre-hookup the DST to skb" uglyness.

L2TP could be modified similarly.

Then the pre-routed SKB code can be removed completely.

Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html