netdev - Re: [PATCH] net/bonding: adjust codingstyle for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110508.171204.27789908.davem@davemloft.net>
Date:	Sun, 08 May 2011 17:12:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hlovdal@...il.com
Cc:	mfmooney@...il.com, joe@...ches.com, aquini@...ux.com,
	kernel-janitors@...r.kernel.org, fubar@...ibm.com,
	andy@...yhouse.net, shemminger@...tta.com, netdev@...r.kernel.org,
	nikai@...ai.net
Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files

From: Håkon Løvdal <hlovdal@...il.com>
Date: Mon, 9 May 2011 02:08:41 +0200

> void bond_3ad_state_machine_handler(struct work_struct *work)
> {
>         struct bonding *bond = container_of(work, struct bonding,
>                                             ad_work.work);
>         struct port *port;
>         struct aggregator *aggregator;
> 
>         read_lock(&bond->lock);
> 
>         if (! bond->kill_timers) {
> 
>                 //check if there are any slaves
>                 if (bond->slave_cnt != 0) {
>                         ...
>                 }
>                 queue_delayed_work(bond->wq, &bond->ad_work, ad_delta_in_ticks);
>         }
>         read_unlock(&bond->lock);
> }
> 
> 
> And this was what I trying to reccommend against (and which the
> stackoverflow question is about).

I really don't see anything wrong with either approach.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html