netdev - Re: [PATCH] veth: use batched device unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1304929236.3342.8.camel@edumazet-laptop>
Date:	Mon, 09 May 2011 10:20:36 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	David Miller <davem@...emloft.net>, Alex Bligh <alex@...x.org.uk>,
	netdev@...r.kernel.org, Jesse Gross <jesse@...ira.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ben Greear <greearb@...delatech.com>
Subject: Re: [PATCH] veth: use batched device unregister

Le lundi 09 mai 2011 à 08:56 +0200, Michał Mirosław a écrit :

> You could change dellink callers to always pass head != NULL. As a
> side effect, unregister_netdevice_queue() would do just what its name
> suggests.

Good idea. At first  glance, macvlan and rtnetlink.c would need a
change.

This would help macvlan_device_event( event=NETDEV_UNREGISTER) use batch
as well.

And yes, unregister_netdevice_queue(dev, head) would only make a

list_move_tail(&dev->unreg_list, head);

Will submit a patch soon, thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html