netdev - Re: [PATCH net-next 0/4] tulip: logging cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110509.114706.189685729.davem@davemloft.net>
Date:	Mon, 09 May 2011 11:47:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/4] tulip: logging cleanups

From: Joe Perches <joe@...ches.com>
Date: Fri,  6 May 2011 19:08:41 -0700

> Joe Perches (4):
>   tulip: xircom_cb: Convert #ifdef DEBUG blocks and enter/leave uses
>   tulip: Convert printks to netdev_<level>
>   tulip: Convert uses of KERN_DEBUG
>   tulip: Use pr_<level> where appropriate

With the advent of the function tracer, those silly function entry/exit
logging things are entirely superfluous.

They make the code look ugly too.

So you have my approval to just kill those things off entirely.

Please do that and respin this patch set, thanks Joe!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html