netdev - Re: [RFC PATCH] net: fold dev_disable_lro() into netdev_fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110509.120811.246541047.davem@davemloft.net>
Date:	Mon, 09 May 2011 12:08:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mirq-linux@...e.qmqm.pl
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, eric.dumazet@...il.com,
	therbert@...gle.com, bhutchings@...arflare.com,
	bridge@...ts.linux-foundation.org
Subject: Re: [RFC PATCH] net: fold dev_disable_lro() into
 netdev_fix_features()

From: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
Date: Sat,  7 May 2011 13:48:02 +0200 (CEST)

> This moves checks that device is forwarding from bridge, IPv4 and IPv6
> code into netdev_fix_features(). As a side effect, after device is no longer
> forwarding it gets LRO back. This also means that user is not allowed to
> enable LRO after device is put to forwarding mode.
> 
> This patch depends on removal of discrete offload setting ethtool ops.
> 
> Signed-off-by: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>

We need to keep the check in the protocols because we don't want to
be testing protocol specific device state in generic code like
net/core/dev.c
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html