[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110509.121107.179924768.davem@davemloft.net>
Date: Mon, 09 May 2011 12:11:07 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: adobriyan@...il.com
Cc: netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH v2] net: add mac_pton() for parsing MAC address
From: Alexey Dobriyan <adobriyan@...il.com>
Date: Sun, 8 May 2011 12:00:07 +0300
> mac_pton() parses MAC address in form XX:XX:XX:XX:XX:XX and only in that form.
>
> mac_pton() doesn't dirty result until it's sure string representation is valid.
>
> mac_pton() doesn't care about characters _after_ last octet,
> it's up to caller to deal with it.
>
> mac_pton() diverges from 0/-E return value convention.
> Target usage:
>
> if (!mac_pton(str, whatever->mac))
> return -EINVAL;
> /* ->mac being u8 [ETH_ALEN] is filled at this point. */
> /* optionally check str[3 * ETH_ALEN - 1] for termination */
>
> Use mac_pton() in pktgen and netconsole for start.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists