netdev - Re: [PATCH] ixgbe: RX ntuple feature must check num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTinq4u321Cf=JtkKOW=6WMP=y78+SQ@mail.gmail.com>
Date:	Tue, 10 May 2011 11:52:02 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Sebastian.Poehn@...den.com
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ixgbe: RX ntuple feature must check num_rx_queues

On Tue, May 10, 2011 at 07:21,  <Sebastian.Poehn@...den.com> wrote:
> The driver must check how much RX queues there are, not TX queues.
>
> --- ixgbe_ethtool.c.orig    2011-05-10 16:18:00.313745560 +0200
> +++ ixgbe_ethtool.c    2011-05-10 16:18:23.285747635 +0200
> @@ -2349,9 +2349,9 @@ static int ixgbe_set_rx_ntuple(struct ne
>
>      /*
>       * Don't allow programming if the action is a queue greater than
> -     * the number of online Tx queues.
> +     * the number of online Rx queues.
>       */
> -    if ((fs->action >= adapter->num_tx_queues) ||
> +    if ((fs->action >= adapter->num_rx_queues) ||
>          (fs->action < ETHTOOL_RXNTUPLE_ACTION_DROP))
>          return -EINVAL;
>
> Signed-off-by: Sebastian Poehn <sebastian.poehn@...den.com>

Thanks Sebastian, I have added the patch to my queue of patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html