netdev - Re: [PATCH] xfrm: Assign the inner mode output function to the dst entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110510.122809.115943941.davem@davemloft.net>
Date:	Tue, 10 May 2011 12:28:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Assign the inner mode output function to the dst
 entry

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Tue, 10 May 2011 07:36:38 +0200

> As it is, we assign the outer modes output function to the dst entry
> when we create the xfrm bundle. This leads to two problems on interfamily
> scenarios. We might insert ipv4 packets into ip6_fragment when called
> from xfrm6_output. The system crashes if we try to fragment an ipv4
> packet with ip6_fragment. This issue was introduced with git commit
> ad0081e4 (ipv6: Fragment locally generated tunnel-mode IPSec6 packets
> as needed). The second issue is, that we might insert ipv4 packets in
> netfilter6 and vice versa on interfamily scenarios.
> 
> With this patch we assign the inner mode output function to the dst entry
> when we create the xfrm bundle. So xfrm4_output/xfrm6_output from the inner
> mode is used and the right fragmentation and netfilter functions are called.
> We switch then to outer mode with the output_finish functions.
> 
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html