netdev - Re: [PATCHv2 net-next-2.6 2/2] qlcnic: Take FW dump via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1C54C9D7-3B1B-47EC-98F5-0A621932D9D4@qlogic.com>
Date:	Tue, 10 May 2011 15:19:19 -0700
From:	Anirban Chakraborty <anirban.chakraborty@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCHv2 net-next-2.6 2/2] qlcnic: Take FW dump via ethtool


On May 10, 2011, at 2:58 PM, Ben Hutchings wrote:

>>>> <snip>
>>> 
>>> This doesn't seem to be serialised with the code that captures firmware
>>> dumps.  They need to use the same lock!
>> When we take the dump, we bring down the interface. So, ethtool will not get a chance to
>> fetch the dump data while the dump operation is in progress.
> [...]
> 
> The ethtool core generally doesn't care whether the interface is
> running.  Its operations are serialised only by the RTNL lock.  The work
> item you added to extract a dump from the NIC does not take that lock.

Oh, ok. Thanks for pointing that out.

-Anirban


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html