netdev - Re: [PATCH RESEND net-next] ethtool: bring back missing comma in netdev features strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110512.175042.1634107025552580202.davem@davemloft.net>
Date:	Thu, 12 May 2011 17:50:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mirqus@...il.com
Cc:	franco@...tsummer.de, netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCH RESEND net-next] ethtool: bring back missing comma in
 netdev features strings

From: Michał Mirosław <mirqus@...il.com>
Date: Thu, 12 May 2011 18:45:12 +0200

> 2011/5/12  <franco@...tsummer.de>:
>> The issue was introduced in commit eed2a12f1ed9aabf.
>>
>> Signed-off-by: Franco Fichtner <franco@...tsummer.de>
>> ---
>>  net/core/ethtool.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>> index b6f4058..b8c2b10 100644
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -361,7 +361,7 @@ static const char
>> netdev_features_strings[ETHTOOL_DEV_FEATURE_WORDS * 32][ETH_GS
>>        /* NETIF_F_NTUPLE */          "rx-ntuple-filter",
>>        /* NETIF_F_RXHASH */          "rx-hashing",
>>        /* NETIF_F_RXCSUM */          "rx-checksum",
>> -       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy"
>> +       /* NETIF_F_NOCACHE_COPY */    "tx-nocache-copy",
>>        /* NETIF_F_LOOPBACK */        "loopback",
>>  };
> 
> Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Applied, but this patch was significantly mangled by your email
client.  Please correct this problem before submitting future
patches, as I will just push them back to you if this happens
again.

Thanks.