lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 May 2011 16:43:22 -0700 From: Stephen Hemminger <shemminger@...tta.com> To: Noah Meyerhans <noahm@...ian.org> Cc: Ben Hutchings <ben@...adent.org.uk>, 625914@...s.debian.org, bridge@...ts.linux-foundation.org, netdev <netdev@...r.kernel.org> Subject: Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4 On Tue, 10 May 2011 16:35:40 -0700 Noah Meyerhans <noahm@...ian.org> wrote: > On Tue, May 10, 2011 at 03:11:00PM -0700, Stephen Hemminger wrote: > > There were two more follow on commits in stable related to this. > > I recommend merging 2.6.38.6 which includes these. > > The problem still exists in the current 2.6.38.6. Backing out 5f1c356a > still solves the problem there. > > I have not yet tried anything outside the stable-2.6.38.y tree, but it > seems like these same changes are present there, and it's unlikely that > other releases will work any better. Does this fix the problem? The tap driver allocates an skb and throws it into the receive path, but the skb does not have the same padding as normal skb's received. --- a/drivers/net/tun.c 2011-05-12 16:36:15.231347935 -0700 +++ b/drivers/net/tun.c 2011-05-12 16:36:38.503464573 -0700 @@ -614,7 +614,7 @@ static __inline__ ssize_t tun_get_user(s } if ((tun->flags & TUN_TYPE_MASK) == TUN_TAP_DEV) { - align = NET_IP_ALIGN; + align = NET_IP_ALIGN + NET_SKB_PAD; if (unlikely(len < ETH_HLEN || (gso.hdr_len && gso.hdr_len < ETH_HLEN))) return -EINVAL; -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists