netdev - Re: [patch 1/9] [PATCH] qeth: convert to hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinO4Hity5++152Ff-RuACFDtoAV2Q@mail.gmail.com>
Date:	Thu, 12 May 2011 07:59:45 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	frank.blaschka@...ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org
Subject: Re: [patch 1/9] [PATCH] qeth: convert to hw_features part 2

2011/5/12  <frank.blaschka@...ibm.com>:
> From: Frank Blaschka <frank.blaschka@...ibm.com>
>
> Set rx csum default to hw checksumming again.
> Remove sysfs interface for rx csum (checksumming) and TSO (large_send).
> With the new hw_features it does not work to keep the old sysfs
> interface in parallel. Convert options.checksum_type to new hw_features.
[...]
> +               /* hw may have changed during offline or recovery */
> +               if (!qeth_is_supported(card, IPA_INBOUND_CHECKSUM)) {
[...]

This check should go to ndo_fix_features callback. If it fails then
just return features &~NETIF_F_RXCSUM from there ...

> +update_feature:
> +       rtnl_lock();
> +       card->dev->hw_features &= ~NETIF_F_RXCSUM;
> +       card->dev->features &= ~NETIF_F_RXCSUM;
> +       netdev_update_features(card->dev);
> +       rtnl_unlock();

... and then this should be just:
rtnl_lock();
netdev_update_features(card->dev);
rtnl_unlock();

BTW, How is the recovery process protected from interface removal if
it's not run under rtnl_lock?

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html