netdev - Re: [PATCH] bonding,llc: Fix structure sizeof incompatibility for some PDUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305216133.3795.31.camel@edumazet-laptop>
Date:	Thu, 12 May 2011 18:02:13 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Vitalii Demianets <vitas@...factor.kiev.ua>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net
Subject: Re: [PATCH] bonding,llc: Fix structure sizeof incompatibility for
 some PDUs

Le jeudi 12 mai 2011 à 08:52 -0700, Joe Perches a écrit :
> On Thu, 2011-05-12 at 18:45 +0300, Vitalii Demianets wrote:
> > On Thursday 12 May 2011 17:33:36 Ben Hutchings wrote:
> > [...]
> > > The '__packed' macro is preferred.
> > Also, I'm slightly in doubt if I should split the patch in 2 parts, one for 
> > bonding an one for LLC?
> 
> What arch needs __packed for
> 
> struct mac_addr {
> 	unsigned char addr[6];
> };
> 
> ?

Believe it or not, they do exist.  (ARM ...)

See "struct ethhdr" definition 

Check commit 7cd636fe9ce5de0051c112 for another argument.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html