netdev - Re: [PATCH v1] bonding,llc: Fix structure sizeof incompatibility for some PDUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110513.151535.291811874627297723.davem@davemloft.net>
Date:	Fri, 13 May 2011 15:15:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vitas@...factor.kiev.ua
Cc:	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net,
	eric.dumazet@...il.com, bhutchings@...arflare.com, joe@...ches.com,
	fubar@...ibm.com, andy@...yhouse.net, acme@...stprotocols.net
Subject: Re: [PATCH v1] bonding,llc: Fix structure sizeof incompatibility
 for some PDUs

From: Vitalii Demianets <vitas@...factor.kiev.ua>
Date: Fri, 13 May 2011 12:04:29 +0300

> With some combinations of arch/compiler (e.g. arm-linux-gcc) the sizeof 
> operator on structure returns value greater than expected. In cases when the 
> structure is used for mapping PDU fields it may lead to unexpected results 
> (such as holes and alignment problems in skb data). __packed prevents this 
> undesired behavior.
> 
> Signed-off-by: Vitalii Demianets <vitas@...factor.kiev.ua>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html