netdev - Re: [PATCH] net: netlink: don't try unicast when dst_pid is zero for NETLINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 May 2011 16:48:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: netlink: don't try unicast when dst_pid is zero
 for NETLINK_USERSOCK

From: Changli Gao <xiaosuo@...il.com>
Date: Fri, 13 May 2011 14:24:54 +0800

> For NETLINK_USERSOCK, no one listens on PID 0, so sending a message only to
> to a multicast group should not return -ECONNREFUSED.
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>

I don't think this is a great idea, creating different semantics for
NETLINK_USERSOCK vs. other types.

You have to set the pid to something which will receive the unicast
message, and then you can also (on top of that) send it to a multicast
group as well.

But the base operation is always the unicast send, and that is what
determines success/failure of the operation.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html