netdev - Re: question about drivers/isdn/hisax/st5481

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305292826.4065.443.camel@localhost>
Date:	Fri, 13 May 2011 14:20:26 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: question about drivers/isdn/hisax/st5481_init.c

On Fri, 2011-05-13 at 07:53 +0200, Julia Lawall wrote:
> The function probe_st5481 allocates an adapter value using kzalloc, adds 
> it to adapter_list, and then performs various initialization operations, 
> which may fail.  adapter_list is a static variable that is never otherwise 
> referenced in the file.  There is a list_del that removes the adapter from 
> the list in the function disconnect_st5481.  The presence of the adapter 
> on the list makes it possibly unsafe to free adapter in the failure cases.
> 
> Could the list just be removed, if it is not being used anywhere?
> 
> Or if the list should be kept because it is useful or it is planned to be 
> useful in the future, could the insertion into the list be moved to the 
> end of the function, after the potentially failing operations, so that 
> adapter can be freed when a failure occurs?

Some older drivers have these device lists hanging around from before
the device model has implemented.  If the list isn't being used now then
it's probably fine to remove.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html