netdev - Re: [RFC 1/3] RDMA: Add netlink infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikpzn6R-QH__dtmwz=fO1QMUN+qag@mail.gmail.com>
Date:	Fri, 13 May 2011 19:18:45 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Joe Perches <joe@...ches.com>
Cc:	Roland Dreier <roland@...nel.org>, Nir Muchtar <nirm@...taire.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [RFC 1/3] RDMA: Add netlink infrastructure

On Fri, May 13, 2011 at 6:44 PM, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2011-05-13 at 09:18 -0700, Roland Dreier wrote:
>> From: Roland Dreier <roland@...estorage.com>
>> [Dave please do not apply even if this ends up in netdev patchwork!]
>
> Just trivia:
>
>> diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
> []
>> +#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__
>
> Using #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
> generally produces smaller overall object size, especially
> at 64 bit.
>
> For instance, here's the size of netlink.o at 32 bit:
>
> $ size drivers/infiniband/core/netlink.o.*
>   text    data     bss     dec     hex filename
>   2663     153     736    3552     de0 drivers/infiniband/core/netlink.o.old
>   2640     153     736    3529     dc9 drivers/infiniband/core/netlink.o.new
>
> Also, I rarely find __func__ useful in message output.
> It may be more useful for active development/debugging.

A recent dynamic debug patch made it possible to enable/disable at
runtime whether or not the function name (and more) should be included
in the output. See also http://lwn.net/Articles/434833/ for more
information.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html