| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110516.190615.2121423692228640268.davem@davemloft.net> Date: Mon, 16 May 2011 19:06:15 -0400 (EDT) From: David Miller <davem@...emloft.net> To: herbert@...dor.hengli.com.au Cc: mirqus@...il.com, mst@...hat.com, shanwei@...fujitsu.com, mirq-linux@...e.qmqm.pl, netdev@...r.kernel.org, bhutchings@...arflare.com Subject: Re: tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG From: Herbert Xu <herbert@...dor.hengli.com.au> Date: Tue, 17 May 2011 08:46:58 +1000 > On Mon, May 16, 2011 at 02:24:19PM +0200, Michaİİ Mirosİİaw wrote: >> >> In this case - no. Those messages inform that driver supports more >> feature combinations than network core and the feature set is reduced >> because of that. > > The driver should never even claim to support SG/TSO/UFO if it > does not support checksum. That is the point of the warning. Well the check has to exist somewhere. Currently userspace can configure tun/tap into whatever set of offloads it likes. We're warning when the user asks for something that needs to be corrected. So the only thing you can suggest is to duplicate these changes in the tun/tap driver. But if we do that, and error on bad combinations instead of fixing them up, we know from this discussion that existing virtualization setups and tools are going to stop working. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists