[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110516.115032.697943097693018627.davem@davemloft.net>
Date: Mon, 16 May 2011 11:50:32 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: solar@...nwall.com, segoon@...nwall.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
peak@...o.troja.mff.cuni.cz, kees.cook@...onical.com,
dan.j.rosenberg@...il.com, eugene@...hat.com, nelhage@...lice.com,
kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
yoshfuji@...ux-ipv6.org, kaber@...sh.net
Subject: Re: [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 16 May 2011 09:26:31 +0200
> Le dimanche 15 mai 2011 à 17:44 -0400, David Miller a écrit :
>
>> Just get rid of ping_ioctl() entirely, as that is the effect of
>> this change since inet_ioctl() returns -ENOIOCTLCMD when
>> sk_prot->ioctl is NULL.
>>
>> Also get rid of asm/ioctls.h since that will be no longer needed.
>
> Sure, here is updated version, thanks.
>
> [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
>
> udp_ioctl() really handles UDP and UDPLite protocols.
>
> 1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds
> a frame with bad checksum.
>
> 2) It has a dependency on sizeof(struct udphdr), not applicable to
> ICMP/PING
>
> If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be
> done differently.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Vasiliy Kulikov <segoon@...nwall.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists