netdev - Re: [PATCH 1/1] netlink: nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110516.135110.1328027948753436190.davem@davemloft.net>
Date:	Mon, 16 May 2011 13:51:10 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linville@...driver.com
Cc:	wey-yi.w.guy@...el.com, linux-wireless@...r.kernel.org,
	ipw3945-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] netlink: nla_nest_end return "unsigned init"

From: "John W. Linville" <linville@...driver.com>
Date: Mon, 16 May 2011 13:35:48 -0400

> This should go to netdev@...r.kernel.org instead...
> 
> On Mon, May 16, 2011 at 07:23:30AM -0700, Wey-Yi Guy wrote:
>> skb->len has unsigned int, return the correct value from nla_nest_end call.
>> 
>> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@...el.com>

Plus, the only users of the return value use it to feed "int"
return values of functions.  F.e. net/core/neighbour.c's use
in neightbl_fill_parms().

I don't see this as being any better or worse, and we should
just leave the return value alone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html