netdev - Re: [PATCH] CDC NCM: release interfaces fix in unbind()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110516.151302.89070822321885499.davem@davemloft.net>
Date:	Mon, 16 May 2011 15:13:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alexey.orishko@...il.com
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org, gregkh@...e.de,
	oliver@...kum.org, alexey.orishko@...ricsson.com
Subject: Re: [PATCH] CDC NCM: release interfaces fix in unbind()

From: Alexey Orishko <alexey.orishko@...il.com>
Date: Sun, 15 May 2011 22:28:27 +0200

> Signed-off-by: Alexey Orishko <alexey.orishko@...ricsson.com>

I don't know about this.

The usb_set_intfdata() calls at cdc_ncm_bind() time are unconditional,
and are performed regardless of whether ->data_claimed or
->control_claimed are set.

So conditionalizing the setting of them to NULL here doesn't seem
right at all.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html