lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 May 2011 12:34:01 -0700 From: Ben Greear <greearb@...delatech.com> To: David Miller <davem@...emloft.net> CC: joe@...ches.com, netdev@...r.kernel.org Subject: Re: [PATCH] sk-filter: Rate-limit WARNing, print dbg info. On 05/17/2011 12:23 PM, David Miller wrote: > From: Joe Perches<joe@...ches.com> > Date: Tue, 17 May 2011 11:52:29 -0700 > >> On Tue, 2011-05-17 at 11:30 -0700, greearb@...delatech.com wrote: >>> From: Ben Greear<greearb@...delatech.com> >>> A mis-configured filter can spam the logs with >>> lots of stack traces. Rate-limit the warnings >>> and add printout of the bogus filter information. >>> - WARN_ON(1); >>> + if (net_ratelimit()) { >>> + pr_err("filter: Unknown code: %hu jt: %u tf: %u" >>> + " k: %u\n", >>> + fentry->code, (unsigned int)(fentry->jt), >>> + (unsigned int)(fentry->jf), fentry->k); >>> + WARN_ON(1); >>> + } >> >> Maybe just using WARN is better. > > Yep, it looks better to me. You want to just take his, or shall I re-spin it? Either is fine with me. Thanks, Ben > >> I believe the casts aren't necessary. > > Also correct. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Greear <greearb@...delatech.com> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists