lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 May 2011 18:32:17 -0400 From: Paul Moore <paul.moore@...com> To: huzaifas@...hat.com Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, kaber@...sh.net, yoshfuji@...ux-ipv6.org, jmorris@...ei.org, pekkas@...core.fi, kuznet@....inr.ac.ru Subject: Re: [PATCH] Check the value of doi before referencing it On Wednesday, May 18, 2011 1:04:53 AM David Miller wrote: > From: Huzaifa Sidhpurwala <huzaifas@...hat.com> > Date: Wed, 18 May 2011 09:59:40 +0530 > > > Value of doi is not checked before referencing it. > > Though this does not cause any null pointer dereference since > > all the callers of cipso_v4_doi_add check the value of doi > > before calling the function, but it would be a good programming > > practice to do so anyways :) > > > > Signed-off-by: Huzaifa Sidhpurwala <huzaifas@...hat.com> > > I don't think we should fix bugs that do not exist. I agree with David. If there were a large number of callers or cipso_v4_doi_add() was a more general function there might be some merit in performing more sanity checks on the values passed to the function. However, as it stands, cipso_v4_doi_add() is a fairly specialized function which is called by a small number of functions all of which are internal to NetLabel. -- paul moore linux @ hp -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists