netdev - Re: [PATCH v4 01/27] HFI: skeleton driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DD6B4FE.9010309@linux.vnet.ibm.com>
Date:	Fri, 20 May 2011 13:37:50 -0500
From:	Brian King <brking@...ux.vnet.ibm.com>
To:	dykmanj@...ux.vnet.ibm.com
CC:	netdev@...r.kernel.org,
	Piyush Chaudhary <piyushc@...ux.vnet.ibm.com>,
	Fu-Chung Chang <fcchang@...ux.vnet.ibm.com>,
	"William S. Cadden" <wscadden@...ux.vnet.ibm.com>,
	"Wen C. Chen" <winstonc@...ux.vnet.ibm.com>,
	Scot Sakolish <sakolish@...ux.vnet.ibm.com>,
	Jian Xiao <jian@...ux.vnet.ibm.com>,
	"Carol L. Soto" <clsoto@...ux.vnet.ibm.com>,
	"Sarah J. Sheppard" <sjsheppa@...ux.vnet.ibm.com>
Subject: Re: [PATCH v4 01/27] HFI: skeleton driver

On 04/25/2011 04:23 PM, dykmanj@...ux.vnet.ibm.com wrote:
> +static int __init hfidd_mod_init(void)
> +{
> +	int			rc = 0;
> +
> +	rc = hfidd_create_class();
> +	if (rc < 0) {
> +		printk(KERN_ERR "%s: hfidd_mod_init: hfidd_create_class failed"
> +			" rc=%d\n", HFIDD_DEV_NAME, rc);
> +		return rc;
> +	}
> +
> +	printk(KERN_INFO "IBM hfi device driver loaded sucessfully\n");
> +	return 0;
> +}

This driver doesn't seem to attach to a bus like a normal driver, which breaks
things like udev being able to automatically load the driver, for example. It
also breaks tools trying to correlate between the kernel logical device and
the device in the device tree. It seems like you depend on and use a bit of
the ibmebus infrastructure. Can we have this device off that bus? 

Thanks,

Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html