netdev - Re: [PATCH] sch_sfq: avoid giving spurious NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110523.173613.2131279677585645313.davem@davemloft.net>
Date:	Mon, 23 May 2011 17:36:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net, jarkao2@...il.com,
	hadi@...erus.ca, shemminger@...tta.com
Subject: Re: [PATCH] sch_sfq: avoid giving spurious NET_XMIT_CN signals

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 23 May 2011 23:02:42 +0200

> While chasing a possible net_sched bug, I found that IP fragments have
> litle chance to pass a congestioned SFQ qdisc :
> 
> - Say SFQ qdisc is full because one flow is non responsive.
> - ip_fragment() wants to send two fragments belonging to an idle flow.
> - sfq_enqueue() queues first packet, but see queue limit reached :
> - sfq_enqueue() drops one packet from 'big consumer', and returns
> NET_XMIT_CN.
> - ip_fragment() cancel remaining fragments.
> 
> This patch restores fairness, making sure we return NET_XMIT_CN only if
> we dropped a packet from the same flow.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Looks good, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html