netdev - Re: [PATCH net-next-2.6] net: remove synchronize_net() from netdev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110522.210326.1316361026223897933.davem@davemloft.net>
Date:	Sun, 22 May 2011 21:03:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com, jpirko@...hat.com
Subject: Re: [PATCH net-next-2.6] net: remove synchronize_net() from
 netdev_set_master()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 20 May 2011 07:37:40 +0200

> In the old days, we used to access dev->master in __netif_receive_skb()
> in a rcu_read_lock section.
> 
> So one synchronize_net() call was needed in netdev_set_master() to make
> sure another cpu could not use old master while/after we release it.
> 
> We now use netdev_rx_handler infrastructure and added one
> synchronize_net() call in bond_release()/bond_release_all()
> 
> Remove the obsolete synchronize_net() from netdev_set_master() and add
> one in bridge del_nbp() after its netdev_rx_handler_unregister() call.
> 
> This makes enslave -d a bit faster.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Jiri Pirko <jpirko@...hat.com>
> CC: Stephen Hemminger <shemminger@...tta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html