netdev - Re: [PATCH] net: ping: cleanups ping_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110523084308.GA6244@albatros>
Date:	Mon, 23 May 2011 12:43:08 +0400
From:	Vasiliy Kulikov <segoon@...nwall.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: ping: cleanups ping_v4_unhash()

On Mon, May 23, 2011 at 10:23 +0200, Eric Dumazet wrote:
> net/ipv4/ping.c: In function ‘ping_v4_unhash’:
> net/ipv4/ping.c:140:28: warning: variable ‘hslot’ set but not used
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Acked-by: Vasiliy Kulikov <segoon@...nwall.com>

hslot was used for debugging purposes here.


BTW, what gcc version do you use?  I have no warning with 4.4.3
(Ubuntu 4.4.3-4ubuntu5):

    $ make net/ipv4/ping.o
      CHK     include/linux/version.h
      CHK     include/generated/utsrelease.h
      CALL    scripts/checksyscalls.sh
      CC      net/ipv4/ping.o
    $


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html